[210_15] srfi-19 time-utc date相互转化实现 #403
Merged
+175
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2026 09:34
jetjinser
reviewed
Feb 12, 2026
Collaborator
jetjinser
left a comment
jetjinser
left a comment
There was a problem hiding this comment.
;; 2000-02-29 leap day
(let* ((d1 (make-date 0 0 0 0 29 2 2000 0))
(t (date->time-utc d1))
(d2 (time-utc->date t)))
(check (date-year d2) => 2000)
(check (date-month d2) => 2) ; got 3
(check (date-day d2) => 29)) ; got 1
这个结果算错的。可以检查下 priv:days-before-year，再多加些类似的边界的测试
Comment on lines
+419
to
+423
| (define (priv:days-before-year year) | ||
| (+ (* 365 year) | ||
| (floor-quotient year 4) | ||
| (- (floor-quotient year 100)) | ||
| (floor-quotient year 400))) |
jetjinser
reviewed
Feb 12, 2026
Comment on lines
+814
to
+820
| #| | ||
| time-utc->date | ||
| 将 TIME-UTC 时间对象转换为日期对象。 | ||
|
|
||
| date->time-utc | ||
| 将日期对象转换为 TIME-UTC 时间对象。 | ||
| |# |
Collaborator
There was a problem hiding this comment.
写得太简略了。另外
time-utc->date time-utc [tz-offset] -> time-utc
Convert UTC time to date, using time zone offset, which defaults to the local time zone.
规范中要求使用本地时区，虽然现在没有做接口（得到当前时区），但是这一点要明确写出来。留个 TODO 之后需要实现
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.