Open
Conversation
Contributor
|
Unit tests needed for this pull request |
da-liii
reviewed
Jul 12, 2024
| all_accessible (outer)) | ||
| return env; | ||
| return ""; | ||
| return tree (ATTR); |
Contributor
|
CI卡了，需要升级macOS 11到macOS 12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initializing drd struct from tree, some tree containing attributes is created and inserted into drd entry. These tree is supposed to be
<attr|...>, but some code will return empty string as "no attributes". Because lolly 1.4.25 changes layout of string, behavior of retrieving array from atomic(string) tree differs from previous version of lolly. Thus tests in mogan on linux fails with corrupted memory. This pr use compound tree instead of string to represent<attr|>, and crash of test is fixed.