[WIP] feat: Add top-environment parameter to the workspace type#18
Closed
VSteveHL wants to merge 4 commits intoMoganLab:mainfrom
Closed
[WIP] feat: Add top-environment parameter to the workspace type#18VSteveHL wants to merge 4 commits intoMoganLab:mainfrom
VSteveHL wants to merge 4 commits intoMoganLab:mainfrom
Conversation
I have modified the `.github/workflows/release.yaml` file and made the following changes:
- Removed the `repo` variable:
- This variable specifies which repository the release targets. Since its default value is the current repository, I believe leaving it empty is reasonable.
- Added `name`
- Added `tag_name`
- Added `body` to provide some contextual information.
In commit 0d79527, a modification was made to `.github/workflows/release.yaml`, adding the `--static` parameter in the "Compile executable on Linux musl" step. However, the corresponding `Dockerfile.musl` was not updated, which caused errors during the build process. This commit adds the `util-linux-static` package to `Dockerfile.musl`, allowing the build to proceed successfully.
- Added (immutable top-environment) to define-record-type workspace - Modified the refresh-workspace function to determine which filter to use based on top-environment
Collaborator
|
Orz this issue includes something failed in #17 , you should seperate them into two branch so that one's failure won't bother another. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After introducing this change, a test that uses r7rs as the top-environment started to fail. I am still tracking down this bug, so this PR is not yet complete.