feat: Modify GitHub workflow file#19
Merged
ufo5260987423 merged 5 commits intoMoganLab:mainfrom Jul 14, 2025
Merged
Conversation
I have modified the `.github/workflows/release.yaml` file and made the following changes:
- Removed the `repo` variable:
- This variable specifies which repository the release targets. Since its default value is the current repository, I believe leaving it empty is reasonable.
- Added `name`
- Added `tag_name`
- Added `body` to provide some contextual information.
In commit 0d79527, a modification was made to `.github/workflows/release.yaml`, adding the `--static` parameter in the "Compile executable on Linux musl" step. However, the corresponding `Dockerfile.musl` was not updated, which caused errors during the build process. This commit adds the `util-linux-static` package to `Dockerfile.musl`, allowing the build to proceed successfully.
Collaborator
Author
|
Just a quick update on why the release workflow failed. It's not a mistake in the workflow file itself. GitHub Actions has special, stricter security for Pull Requests (especially from forks like mine). This means the GITHUB_TOKEN only has read-only access during PRs, so it can't create releases. It's a built-in safety feature from GitHub to protect the main repository. |
Collaborator
Author
|
And I think our musl build was an innocent bystander in this permission issue. 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have modified the
.github/workflows/release.yamlfile and made the following changes:repovariable:nametag_namebodyto provide some contextual information.It is worth noting that in the softprops/action-gh-release action, the overwrite_files variable defaults to True. This means that when we explicitly specify a tag_name, the workflow will not repeatedly create new releases but will instead update the files associated with the specified tag. I think this behavior is reasonable for automated builds. However, if you consider this behavior inappropriate, we could modify the tag_name to a format like automated_build-${{ github.run_number }}. This way, a new release would be created for each commit.
For more configurable options in softprops/action-gh-release, you can refer to: softprops/action-gh-release#inputs