Fix: don't fail entire rewrite if recursive type did not match anywhere at top-level #85
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually, rewrites to recursive types are deeply nested - which will cause any failure to fallback to no-op (through most
Type.all()
implementations). The semantics ofeverywhere
are similar toall
- if nothing can be rewritten internally, that is not an error state.This will cause no fixer function to be produced if a top-level recursive type has a fixer defined within a version range, but that type does not exist within the type being fixed.
Doesn't currently impact Vanilla, but became a bit more likely with 1a8eb41.