Account for multiple re-renders #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eokoneyo
force-pushed
the
fix/account-for-multiple-renders
branch
from
2987bf1 to
b80e308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement
When sveltris is used to render a svelte component within react, if it happens that in the parent component that renders the svelte component multiple re-renders occur for any specific reason in the current implementation after the first render the value of
svelteComponentRef.currentbecomes stale, and as such the component will not get rendered.This proposed change set makes it such that multiple re-renders are accounted for, by updating the value for the target of the svelte mount to always point to the current wrapper dom node.