Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molecules coming from the DB should be marked as validated #798

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

bennybp
Copy link
Contributor

@bennybp bennybp commented Jan 6, 2024

Description

Molecules in the database are already validated, however this validation flag is not stored in the database (since it is always True). However, we need to set it again when converting from the MoleculeORM or else clients will need to re-validate them, which is a fairly expensive process.

See #742 (comment)

This PR also improves record handling in datasets slightly, by using the record-specific endpoints. This avoids a relatively expensive query, although tangible improvements will likely be small.

One more thing I tacked on - handle fix_com and fix_orientation the same way - as a column_property with a fixed value, rather than an actual stored column

Changelog description

Mark molecules coming from the server as already validated

Remove fix_com and fix_orientation from the molecules table and make them column_propertys

Status

  • Code base linted
  • Ready to go

@bennybp bennybp mentioned this pull request Jan 6, 2024
@bennybp bennybp merged commit 9754250 into main Jan 8, 2024
17 checks passed
@bennybp bennybp deleted the mol_validate branch January 8, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant