Molecules coming from the DB should be marked as validated #798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Molecules in the database are already validated, however this validation flag is not stored in the database (since it is always
True
). However, we need to set it again when converting from the MoleculeORM or else clients will need to re-validate them, which is a fairly expensive process.See #742 (comment)
This PR also improves record handling in datasets slightly, by using the record-specific endpoints. This avoids a relatively expensive query, although tangible improvements will likely be small.
One more thing I tacked on - handle
fix_com
andfix_orientation
the same way - as acolumn_property
with a fixed value, rather than an actual stored columnChangelog description
Mark molecules coming from the server as already validated
Remove
fix_com
andfix_orientation
from the molecules table and make themcolumn_property
sStatus