Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sqlite3 with apsw #829

Merged
merged 1 commit into from
May 6, 2024
Merged

Replace sqlite3 with apsw #829

merged 1 commit into from
May 6, 2024

Conversation

bennybp
Copy link
Contributor

@bennybp bennybp commented May 6, 2024

Description

Replaces the use of sqlite3 from the python standard library with APSW (https://github.com/rogerbinns/apsw, https://rogerbinns.github.io/apsw/index.html)

APSW is a lightweight wrapper around sqlite that allows for more features compared to the python standard library (which is constrained by the DB API).

In particular, APSW allows for multi-threaded access to connections, which means I can remove some kinda hacky thread-local stuff. And since I can remove that, I don't need to use the memdb vfs, which seems constrained in the size of the db (whereas :memory: seems unconstrained). So that should prevent things like #820

It also allows for some more advanced features that I may use in the future.

Changelog description

Replace use of Python sqlite3 with APSW

Status

  • Code base linted
  • Ready to go

@bennybp bennybp merged commit e16b51f into main May 6, 2024
16 of 17 checks passed
@bennybp bennybp deleted the apsw branch May 6, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant