add Coding subdirectory, #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgasmith
reviewed
Jan 27, 2018
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Please delete this file.
| @@ -0,0 +1,377 @@ | |||
| package org.jmol.adapter.readers.quantum; | |||
|
|
|||
There was a problem hiding this comment.
Can we simply put this in a Coding/Java/... folder. The additional nesting too much I would think.
| /** | ||
| * Read basis and orbital information. | ||
| * | ||
| * @param molecular_orbitals |
There was a problem hiding this comment.
Can we provide much more information of what the molecular_orbitals object entails?
| + Viewer.getJmolVersion().replace(' ', '_'); | ||
|
|
||
| // | ||
| // source: http://cccbdb.nist.gov/hartree.asp |
There was a problem hiding this comment.
This is quite limiting in terms of accuracy. Please see here for better precision:
https://physics.nist.gov/cuu/Constants/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a place for C++ or Java code development; adds Jmol's QC-JSON reader and writer; adds a generally-useful Java class for working with QC-Schema units and unit conversion.
Questions
Status