Name Regex filter enhancements #9917
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fixing the known false-positives, but if you do that before me, that's fine. |
Booplicate
requested changes
Feb 20, 2023
| @@ -516,6 +516,7 @@ label mas_player_name_enter_name_loop(input_prompt): | |||
| ).strip(' \t\n\r') | |||
|
|
|||
| lowername = tempname.lower() | |||
| alphaname = re.sub("[^a-zA-Z0-9]", "", tempname) | |||
There was a problem hiding this comment.
I would suggest using \s as that should catch any kind of space while allowing every other symbol (think about translations that might allow different characters, or maybe if we get proper unicode support in the future).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, this is aimed at hardening the filter against workarounds such as doing
m o m m ysort of trick by adding spaces; this is mitigated by completely stripping all non-alphanumeric characters and performing match against the result string.Moreover, I also plan on modifying existing expressions so that they also account for 1337speak (e.g. replacing
owith0and alike).In addition to that (though, probably it's better to make it a separate PR) I want to try to exclude possible false positives.