TGUI & Garbage Collector Updates

.github/workflows/generate_client_storage.yml

@@ -0,0 +1,33 @@
+name: "Generate Client Storage"
+on:
+  push:
+    branches:
+      - master
+    paths:
+      - tgui/public/*
+
+jobs:
+  dispatch_repo:
+    if: ( !contains(github.event.head_commit.message, '[ci skip]') )
+    name: Repository Dispatch
+    runs-on: ubuntu-latest
+    steps:
+      - name: Generate App Token
+        id: app-token-generation
+        uses: actions/create-github-app-token@v2
+        if: env.APP_PRIVATE_KEY != '' && env.APP_ID != ''
+        with:
+          app-id: ${{ secrets.APP_ID }}
+          private-key: ${{ secrets.APP_PRIVATE_KEY }}
+          owner: tgstation
+        env:
+          APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
+          APP_ID: ${{ secrets.APP_ID }}
+
+      - name: Send Repository Dispatch
+        if: success()
+        uses: peter-evans/repository-dispatch@v4
+        with:
+          token: ${{ steps.app-token-generation.outputs.token }}
+          repository: tgstation/byond-client-storage
+          event-type: on_master_push

cev_eris.dme

@@ -365,6 +365,7 @@
 #include "code\datums\datum.dm"
 #include "code\datums\datum_click_handlers.dm"
 #include "code\datums\datum_hud.dm"
+#include "code\datums\datumvars.dm"
 #include "code\datums\footsteps.dm"
 #include "code\datums\gps_data.dm"
 #include "code\datums\hierarchy.dm"

code/__DEFINES/tgui.dm

@@ -24,6 +24,17 @@
 /// Window is free and ready to receive data
 #define TGUI_WINDOW_READY 2
 
+/// Though not the maximum renderable ByondUis within tgui, this is the maximum that the server will manage per-UI
+#define TGUI_MANAGED_BYONDUI_LIMIT 10
+
+
+// These are defines instead of being inline, as they're being sent over
+// from tgui-core, so can't be easily played with
+#define TGUI_MANAGED_BYONDUI_TYPE_RENDER "renderByondUi"
+#define TGUI_MANAGED_BYONDUI_TYPE_UNMOUNT "unmountByondUi"
+
+#define TGUI_MANAGED_BYONDUI_PAYLOAD_ID "renderByondUi"
+
 /// Get a window id based on the provided pool index
 #define TGUI_WINDOW_ID(index) "tgui-window-[index]"
 /// Get a pool index of the provided window id
@@ -36,3 +47,4 @@
 #define TGUI_CREATE_MESSAGE(type, payload) ( \
 	"%7b%22type%22%3a%22[type]%22%2c%22payload%22%3a[url_encode(json_encode(payload))]%7d" \
 )
+

code/_compile_options.dm

@@ -21,6 +21,10 @@
 ///Used for doing dry runs of the reference finder, to test for feature completeness
 //#define REFERENCE_TRACKING_DEBUG
 
+/// If this is uncommented, additional logging (such as more in-depth tgui logging) will be enabled.alist
+/// These logs prolly don't matter during production.
+// #define EXTENDED_DEBUG_LOGGING
+
 ///Run a lookup on things hard deleting by default.
 //#define GC_FAILURE_HARD_LOOKUP
 #ifdef GC_FAILURE_HARD_LOOKUP
@@ -75,7 +79,7 @@
 #error You need version 516.1651 or higher
 #endif
 #if defined(OPENDREAM) && (DM_VERSION < MIN_COMPILER_VERSION || DM_BUILD < MIN_COMPILER_BUILD)
 #warn This version of OpenDream is below the minimum required for this project. Some linter errors may be incorrect.
 #endif
 
 //Additional code for the above flags.

code/_global_vars/misc.dm

@@ -33,4 +33,4 @@ GLOBAL_LIST_INIT(custom_kits, list(
 GLOBAL_DATUM(changelog_tgui, /datum/changelog)
 
 // FIXME FIXME FIXME TURN THIS BACK OFF WHEN YOU'RE DONE DIPSHIIIIIIIITTT!
-GLOBAL_VAR_INIT(Debug2, TRUE)
+GLOBAL_VAR_INIT(Debug2, FALSE)

code/controllers/configuration/entries/general.dm

@@ -489,6 +489,15 @@
 	default = -1
 	min_val = 0
 
+/datum/config_entry/number/hard_deletes_overrun_threshold
+	integer = FALSE
+	min_val = 0
+	default = 0.5
+
+/datum/config_entry/number/hard_deletes_overrun_limit
+	default = 0
+	min_val = 0
+
 /*****************/
 /*   COOLDOWNS   */
 /*****************/

code/controllers/configuration/entries/resources.dm

@@ -50,3 +50,7 @@
 	if (str_var && str_var[length(str_var)] != "/")
 		str_var += "/"
 	return ..(str_var)
+
+/datum/config_entry/string/storage_cdn_iframe
+	protection = CONFIG_ENTRY_LOCKED
+	default = "https://tgstation.github.io/byond-client-storage/iframe.html"