Skip to content

[BOUNTY] Fixes player PM responses not being added to a ticket's msg history and also staling weirdness #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sun-Soaked wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[BOUNTY] Fixes player PM responses not being added to a ticket's msg history and also staling weirdness #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2ebbf5
Merge pull request #6 from Monkestation/master
Sun-Soaked Feb 12, 2026
610a18a
heroic 4 line bugfix strikes again
Sun-Soaked Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion code/controllers/subsystems/tickets/tickets.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,8 @@ SUBSYSTEM_DEF(tickets)
ckey = astype(ckey, /client).ckey

for(var/datum/ticket/T in allTickets)
if(T.client_ckey == ckey && T.ticketState == TICKET_OPEN && (T.ticketCooldown > world.time))
//todo: remove the stupid staling system alltogether or do monke admin tickets god please I beg
if(T.client_ckey == ckey && (T.ticketState == TICKET_OPEN || T.ticketState == TICKET_STALE) && (T.ticketCooldown > world.time))
return T
return FALSE

Expand Down
4 changes: 2 additions & 2 deletions code/modules/admin/verbs/adminpm.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,10 @@
i.addResponse(src, msg) // Add this response to their open tickets.
return
if(type == "Mentorhelp")
if(check_rights(R_ADMIN|R_MENTOR, 0, C.mob)) //Is the person being pm'd an admin? If so we check if the pm'er has open tickets
if(check_rights_for(C, R_ADMIN|R_MENTOR)) //Is the person being pm'd an admin? If so we check if the pm'er has open tickets
tickets = SSmentor_tickets.checkForTicket(src)
else // Ahelp
if(check_rights(R_ADMIN, 0, C.mob)) //Is the person being pm'd an admin? If so we check if the pm'er has open tickets
if(check_rights_for(C, R_ADMIN)) //Is the person being pm'd an admin? If so we check if the pm'er has open tickets
tickets = SStickets.checkForTicket(src)

if(tickets)
Expand Down
Loading