[wip] Butchering 2.0 [Commission]#259
Draft
Sun-Soaked wants to merge 6 commits intoMonkestation:masterfrom
Draft
[wip] Butchering 2.0 [Commission]#259Sun-Soaked wants to merge 6 commits intoMonkestation:masterfrom
Sun-Soaked wants to merge 6 commits intoMonkestation:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Comissioned by @blackwolf602
This pr fully replaces the butchering system with a centralized component 'ported' from tg/monke main (I had to pretty much rewrite it from the ground up but let's ignore that)

And standardizes the weird cross-type behavior for butchering simple_animals and superior_animals (though humans still have their own weird butchering logic going on)
Mobs can now have a list called
butcher_resultsdefined that contains their possible butchering drops, which are iterated through when butchering the mob, with the assigned number determining their base chance of dropping(this means they can have multiple different butcher drops, and different drops can have different chances of dropping)
In terms of player-faching changes:
Balance(especially of butcher drop chances) is very subject to change & I'm open to any suggestions
Why It's Good For The Game
Makes our butchering system less shitcode and more flexible, while also connecting it to the tool and stat mechanics. Requested by Lord Rook so they can implement the roach loot pool & some of the negative butchering effects described in the techno document in their own future prs
Testing
Runs. Butchering works. Will continue testing when I'm less tired
Changelog
🆑
code: butchering is now handled by the Butchering component, automatically placed on sharp items
balance: the chance of successfully harvesting meat from a mob is now effected by BIO and the cutting power of the tool used
balance: any sharp item can now be used to butcher mobs. items with no cutting power are treated as if they have QUALITY_CUTTING 5(very weak)
balance: club roles now get some bio for better butchering
code: adds a system to cause potential negative effects when poorly butchering mobs
fix: several minor simplemobs now correctly drop a small amount of meat
add: cat meat.
add: iriska meat.
/:cl: