[PORT] Improves tgui build speed #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swaps out our minimizer, Terser, with esbuildplugin. This is the engine behind vite. This is a pretty straight forward replacement, let's let the numbers do the talking: <details> <summary>Test environment / My specs</summary> intel i7-13700kf 32GB RAM windows 11 intel 660p m.2 SSD asus 4080 TUF series </details> <details> <summary>Fresh build</summary> Test steps: 1. Delete `tgui/.yarn/webpack` folder 2. `CTRL SHIFT B` Results:  terser averages `25.16s` esbuild averages `19.37s` - 23% faster </details> <details> <summary>Cached build</summary> (assuming files are already there, CTRL SHIFT B if not) 1. add a comment to an interface file 2. `CTRL SHIFT B` Results:  terser averages `9s` esbuild averages `3.52s` - 60.91% faster </details> Faster dev environment N/A nothing player facing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation/tgstation#79916
Changelog
No user-facing changes