[PORT] Fix advanced proximity monitors being 1 tile too small #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4307) Fixes #84301 Right here, https://github.com/tgstation/tgstation/blob/d1051ec8a80b34ca3f3cab2a14e75421e3bae3d6/code/datums/proximity_monitor/field.dm#L129-L132 We get the inner turfs and then use them to find the outer turfs But We subtract the inner turfs from the outer turfs instead of subtracting the outer turfs from the inner turfs... (also adds a unit test and updates the field debugger for better field debugging) :cl: Melbert fix: Fix timestop being 1 tile too small again, and fixes a lot of other field effects from being 1-small as well /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports tgstation/tgstation#84307
🆑 Melbert
fix: Fix timestop being 1 tile too small again, and fixes a lot of other field effects from being 1-small as well
/:cl: