-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monster Hunters can now see rabbits through walls (+ silver bullets are now a status effect) #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2024
Open
Closed
Open
Closed
This was referenced Sep 27, 2024
Open
This was referenced Sep 30, 2024
Closed
the greater rework will be a later pr i guess |
just double checked to ensure this properly works on multi-z (it does) i haven't had any complaints or reports about it, should be ready to go @ThePooba |
This was referenced Oct 3, 2024
This was referenced Oct 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This makes it so monster hunters can see rabbits through walls, like so:
Also, changes the bloodsilver bullets to apply a status effect that causes slowdown, rather than just applying the movespeed with a timer to unset it.
Why It's Good For The Game
Rabbit hunting is notoriously an unfun, pain in the ass part of playing MH sometimes, hopefully this should make it less so, while I work on further improvements.
Also, the code for the silver bullets was janky, and it wasn't entirely clear what the hell was going on either.
Changelog
🆑
qol: Monster Hunters can now see rabbits through walls.
qol: Monster Hunters interacting with a rabbit will now automatically pickup the loot if they have room in their hands.
refactor: Made the rabbit code a bit less shit (in exchange for some annoyingly necessary jank)
qol: The slowdown from bloodsilver bullets is now a status effect, and will be refreshed if another bullet hits before it finishes.
/:cl: