Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Reworks bloodsuckers into vampires #3595

Draft
wants to merge 116 commits into
base: master
Choose a base branch
from

Conversation

RikuTheKiller
Copy link
Contributor

@RikuTheKiller RikuTheKiller commented Sep 28, 2024

About The Pull Request

Reworks the bloodsucker antagonist in it's entirety.

HackMD: https://hackmd.io/zzopefuDQ7CzVom4pPrvJw?view

Changelog

🆑
add: Bloodsuckers have been reworked into vampires. The old code was obliterated.
/:cl:

Copy link
Contributor

@JohnFulpWillard JohnFulpWillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty cool

@@ -9,11 +9,13 @@ GLOBAL_LIST_INIT(guardian_radial_images, setup_guardian_radial())
option.info = span_boldnotice(initial(guardian_path.creator_desc))
.[guardian_path] = option

/* ONGOING VAMPIRE REWORK, FIX THIS ONCE YOU KNOW WTF TO DO WITH IT
Copy link
Contributor

@JohnFulpWillard JohnFulpWillard Sep 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, others not getting it is because it was added as a jojo reference. Doesn't even need to stick around if you want to just kill it

Copy link
Contributor Author

@RikuTheKiller RikuTheKiller Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely going to fix it rather than kill it. The code will be left commented for the initial PR, though.

if(regen_rate <= 0) // sanity check
return

if(owner.stat == DEAD)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No extra healing in a coffin? Vamp species does

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Planned, as stated in the HackMD.

Absolucy and others added 2 commits September 30, 2024 13:23
…ecuperation.dm

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants