Check Players adminverb + other admin verb fixes #4030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check Players adminverb to quickly and precisely check how many connected clients of several categories: Connected Clients, Living Players, Dead Players, Ghost Players, Living Antags.
Absolucy
requested changes
Nov 3, 2024
monkestation/code/modules/veth_misc_items/admin_fixes/check_players.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/veth_misc_items/admin_fixes/check_players.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/veth_misc_items/admin_fixes/check_players.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/veth_misc_items/admin_fixes/check_players.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/veth_misc_items/admin_fixes/check_players.dm
Outdated
Show resolved
Hide resolved
| @@ -4,7 +4,7 @@ | |||
| set desc = "You can modifiy a targets metacoin balance by adding or subtracting." | |||
|
|
|||
| var/mob/chosen_player | |||
| chosen_player = tgui_input_list(src, "Choose a Player", "Player List", GLOB.player_list) | |||
| chosen_player = tgui_input_list(src, "Choose a Player", "Player List", GLOB.clients) | |||
There was a problem hiding this comment.
you won't get a mob from GLOB.clients - you'll get a, well, client.
I don't think I can check adjust_metacoins properly (or at least I can't figure out how to get it to work) so I have reverted to what it was before
Absolucy
reviewed
Nov 7, 2024
monkestation/code/modules/veth_misc_items/admin_fixes/check_players.dm
Outdated
Show resolved
Hide resolved
This was referenced Nov 7, 2024
Open
This was referenced Nov 8, 2024
Closed
Absolucy
requested changes
Nov 8, 2024
monkestation/code/modules/veth_misc_items/admin_fixes/check_players.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/veth_misc_items/admin_fixes/check_players.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/veth_misc_items/admin_fixes/check_players.dm
Outdated
Show resolved
Hide resolved
| @@ -4,7 +4,7 @@ | |||
| set desc = "You can modifiy a targets metacoin balance by adding or subtracting." | |||
|
|
|||
| var/mob/chosen_player | |||
| chosen_player = tgui_input_list(src, "Choose a Player", "Player List", GLOB.player_list) | |||
| chosen_player = tgui_input_list(src, "Choose a Player", "Player List", GLOB.clients) | |||
|
fix conflicts |
tested, still works, hopefully fixes merge conflict
|
it should be up to date now, it hates me, kill me thanks |
Absolucy
requested changes
Nov 13, 2024
monkestation/code/modules/veth_misc_items/admin_fixes/check_players.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/veth_misc_items/admin_fixes/check_players.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/veth_misc_items/admin_fixes/check_players.dm
Outdated
Show resolved
Hide resolved
Requested changes are in, thanks for all your hard work looking at my code Lucy!
These should all be fixed now, thanks for the advice. Can I ask why not to use usr over something else? (just to improve my code and stuff, out of curiosity.) Thanks for all your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Check Players adminverb to quickly and precisely check how many connected clients of several categories: Connected Clients, Living Players, Dead Players, Ghost Players, Living Antags.
Fixes to Adjust Event Tokens, Adjust Antag Tokens to work off of ckey instead of Character Name.
Adjust metacoins was unchanged due to the fact I can't test if it's broken.
Why It's Good For The Game
Admin tools!!
Changelog
🆑
admin: Added Check Players verb
admin: Fixed Adjust Event Tokens to work off of ckey instead of Character Name
admin: Fixed Adjust Antag Tokens to work off of ckey instead of Character Name
/:cl: