Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some ai voxlines that I can't see being used in a non-rule-breaking way #5658

Merged

Conversation

LikeLakers2
Copy link
Collaborator

@LikeLakers2 LikeLakers2 commented Feb 25, 2025

About The Pull Request

This PR attempts to be a subset of removals taken from #4254, but only those that would only be usable in a rule-breaking context.

The list of words that were removed are as follows:

  • abortions - There are some legitimate non-political uses of this word - but I can't see any reasonable AI player using this word due to its strong connections to politics. Plus, if we're talking about abortion in a funny spaceman game, it's very likely the round has devolved into real-world politics. (EDIT: I was notified that abortions was used to refer to xeno larvae inside people - but I'm still iffy about it, so I'm going to defer to the admins.)
  • coomer - Sexual word, which will almost certainly be a rule 3 violation whenever used.

Of note, I left certain words in that I wasn't sure about:

  • cunt, wanker - While these can be sexual, they could also be used by the AI to insult someone. I would hope that most players have enough common sense to only use it as an insult.
  • woody - This was likely added as a reference to "Woody's Got Wood" - but the word itself can be used to describe a wood-like area.

Other words that were deleted in the original PR (which included feet, for some reason) are left undeleted here, due to not being rulebreaking.

Why It's Good For The Game

Cleans up some words that would go unused, or would only be usable in a rule-breaking context.

Changelog

🆑MichiRecRoom
del: A couple words have been removed from the AI's vox repertoire - these words were only usable in rule-breaking contexts anyways.
/:cl:

@Kitsunemitsu Kitsunemitsu added Minor Removal a thing is removed labels Feb 26, 2025
@Kitsunemitsu
Copy link
Collaborator

This is something I assume that admins want to approve (It's regarding rules), so I am setting the tag.
Feel free to remove the tag if it's not actually approval required.

@Kitsunemitsu Kitsunemitsu added the awaiting admin review PR is fine code-wise, just needs admin approval now. label Feb 26, 2025
@LikeLakers2
Copy link
Collaborator Author

LikeLakers2 commented Feb 26, 2025

@Kitsunemitsu Thanks. Honestly, I'm not sure either, though I lean towards wanting admins to review this anyways - so I'm going to leave the tag.

I forgot that `wanker` was more of an insult than a sexual word.
@ThePooba ThePooba merged commit 6b56897 into Monkestation:master Mar 1, 2025
27 checks passed
@ThePooba ThePooba added admin approved admins say it's fine, just awaiting code review and removed awaiting admin review PR is fine code-wise, just needs admin approval now. labels Mar 1, 2025
github-actions bot added a commit that referenced this pull request Mar 1, 2025
@LikeLakers2 LikeLakers2 deleted the project/cleanup/vox-line-cleanup branch March 2, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin approved admins say it's fine, just awaiting code review Minor Removal a thing is removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants