Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paco/Taco DLC! Adds seclite functionality, alternate stripeless style and a return to form by returning the Taco back into a Paco. #638

Merged

Conversation

MonstieHuntie
Copy link
Contributor

About The Pull Request

Adds a good bit of stuff for the Paco/Taco!

  • Returns the Taco to Paco, but now every Paco has a 10% chance to spawn as a "Taco", giving a unique title and special examine text!
  • Adds seclite functionality, allowing you to finally put that seclite sitting in your pocket to good use.
  • You can now pick the stripe off the Paco by Alt-Clicking it! Takes about 6 seconds, included with oddly satisfying sounds.
  • In addition to that, you can now add engravings (rename and description) to a Stripeless Paco using the space the red stripe took up.

PacoSecliteFunctionality

StripeRemoval.mp4

Why It's Good For The Game

Adds alot of neat stuff for the Paco that I've seen people ask for every now and then. Seclite functionality will make it a more lucrative option for Security, and the choice of modifying your Paco adds flavor and potential roleplay opportunities. Does in the Taco joke without outright removing it, and making it more special and momentous should you have one! And don't worry, you can check if your Limited Edition Taco is the real deal by looking at the examine text (it's gold!). General fun additions.

Changelog

🆑
add: The Limited Run of "Taco" Edition Pacos have come to an end, returning to form. Every Paco now has a 10% chance of being a Limited Edition model!
add: Adds the Stripeless Paco! Accessible by picking the stripe off of a normal Paco by Alt-Clicking.
balance: Pacos can now use Seclites! A new version of the Paco adds a screw-in slot for Seclites due to popular demand.
/:cl:

-This changes the Taco back to the Paco, a return to form.
-Now every Paco has a 10% chance to spawn with the name Taco, including an extra special examine text. Limited Edition!
-Adds seclite functionality to the Paco.
-You can now rip the stripe off the Paco! You can alt-click a Paco to rip the stripe off, dropping the loaded mag and chambered round if possible to avoid maiming yourself. Sprites included (basically just simple edits of the normal Paco)
Simple but very nice edits of the original paco.
Adds the icons for the Stripeless Paco, inhands for the Stripeless Paco, and seclite sprites for the Paco.
You want to take out the magazine before racking, duh.
@DexeeXI
Copy link
Contributor

DexeeXI commented Dec 5, 2023

Engravings....

Provide no tactical advantage what so ever.

Also, fuck you, Tacos your Paco.

MonstieHuntie and others added 3 commits December 9, 2023 14:28
…escription edits

I completely rewrote how ripping the stripe off the Paco works, decreasing end-user jank infinitely. Now, instead of releasing the mag (into your hand), racking the slide, and completely deleting the original gun and replacing it with a brand new stripeless variant (HOLY MOTHER OF JANK)... It now uses a series of update methods to PROPERLY change the sprites and inhand of the Paco without having to do any convoluted bullshittery (say goodbye to Paco/Stripeless!).

Also incorporates a cooldown to stop players from potentially spamming the AltClick feature to annoy their peers.

Cleans up how updating the description based on if it was a Taco or Stripeless gun. Instead of replacing the description with a new one, it appends a new sentence to it. That means that, if you have a rare Taco edition and decide to rip the stripe off, the fancy description won't disappear, joy!
When I fixed up the code the side effect of the gun needing to rack got removed leaving it sounding a bit empty, returns the satisfaction of hearing the gun react to having the stripe pulled off.
@dwasint dwasint merged commit 82f53d7 into Monkestation:master Jan 10, 2024
13 of 19 checks passed
github-actions bot added a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants