Refactor Guardian Creator item code; Fix Timestop Guardian to not overwrite Standard Guardian #685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR was originally started as a means of fixing Timestop Guardian so that it doesn't overwrite the Standard Guardian. Due to Timestop Guardian's abilities, it is very overpowered compared to Standard Guardian - making it an easy choice since everything else was just worse.
In the process of fixing and testing this, I found that Bloodsuckers would be offered a useless Guardian Type selection - despite the guardian type then being overwritten if you were a Bloodsucker. So I went about refactoring the code to ensure we could skip the type selection if need be.
Please do not merge this yet. It is not finished.
Why It's Good For The Game
Changelog
🆑 MichiRecRoom
fix: Timestop Guardian no longer overwrites the Standard Guardian, which additionally restricts Timestop Guardian to Bloodsuckers (as was intended)
fix: Guardian Timestop spell incorrectly stated that the master was exempt from the Timestop field
refactor: refactor Guardian Creator item code (and the Bloodsucker code along with it)
/:cl: