Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Guardian Creator item code; Fix Timestop Guardian to not overwrite Standard Guardian #685

Closed

Conversation

LikeLakers2
Copy link
Contributor

@LikeLakers2 LikeLakers2 commented Dec 7, 2023

About The Pull Request

This PR was originally started as a means of fixing Timestop Guardian so that it doesn't overwrite the Standard Guardian. Due to Timestop Guardian's abilities, it is very overpowered compared to Standard Guardian - making it an easy choice since everything else was just worse.

In the process of fixing and testing this, I found that Bloodsuckers would be offered a useless Guardian Type selection - despite the guardian type then being overwritten if you were a Bloodsucker. So I went about refactoring the code to ensure we could skip the type selection if need be.

Please do not merge this yet. It is not finished.

Why It's Good For The Game

  1. Guardian Creator item code is not organized well.
  2. The Timestop Guardian shouldn't be overwriting the Standard Guardian.
  3. The Guardian Timestop spell description is wrong. (see Timestop Holoparasite's Timestop ability description wrongly suggests that the master is unaffected by the timestop #648) This fixes the description (subject to reverting if we figure out the spell is supposed to allow the master to move).

Changelog

🆑 MichiRecRoom
fix: Timestop Guardian no longer overwrites the Standard Guardian, which additionally restricts Timestop Guardian to Bloodsuckers (as was intended)
fix: Guardian Timestop spell incorrectly stated that the master was exempt from the Timestop field
refactor: refactor Guardian Creator item code (and the Bloodsucker code along with it)
/:cl:

@LikeLakers2
Copy link
Contributor Author

Closing this to separate this PR into two separate PRs: (1) bugfixes; (2) refactoring.

The bugfixes are important, the refactoring is not.

@LikeLakers2 LikeLakers2 deleted the fix-timestop-guardian branch December 16, 2023 18:54
@LikeLakers2 LikeLakers2 restored the fix-timestop-guardian branch December 16, 2023 18:54
@LikeLakers2 LikeLakers2 deleted the fix-timestop-guardian branch December 16, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant