'Minor' Blood Overhaul - Automatons have oil now.#5329
Open
Ordosian wants to merge 6 commits intoMonkestation:mainfrom
Open
'Minor' Blood Overhaul - Automatons have oil now.#5329Ordosian wants to merge 6 commits intoMonkestation:mainfrom
Ordosian wants to merge 6 commits intoMonkestation:mainfrom
Conversation
| . += image('icons/mob/dam_mob.dmi', "[dmg_overlay_type]_[body_zone]_[brutestate]0_[icon_gender]", -DAMAGE_LAYER, image_dir) | ||
| var/image/brute_image = image('icons/mob/dam_mob.dmi', "[dmg_overlay_type]_[body_zone]_[brutestate]0_[icon_gender]", -DAMAGE_LAYER, image_dir) | ||
| if(owner) | ||
| brute_image.color = owner.get_blood_type().color |
Collaborator
There was a problem hiding this comment.
There should not be a reliance on owner, it won't exist when dropped. see what TG does with cached blood info
Co-authored-by: CheffieGithub <113442598+CheffieGithub@users.noreply.github.com>
Collaborator
|
Can you additionally show what blood pools and damage overlays look like in black/red for oil and blood? Splatters / drops i'm not worried about. And you need to revert the file changes to burn too so it isn't white. |
Collaborator
|
And if you have any trouble with it I reworked all of goons blood to be greyscaled 2 years ago so I have experience with this exact thing |
Author
Collaborator
|
How did you change the pool sprite? It seems like it has much less alpha and has turned into a mostly flat color |
|
Make it so if they bleed over a cup or pot, the fluid thats in it is flammable :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






About The Pull Request
Blood and wounds are now whitescale and use the species blood to paint over it.
This means that AUTOMATONs now have oil as blood and their wounds have oil rather than blood.
Automaton bleed rate is 0.2 currently which is 80% less bleed rate from injuries. This is too avoid people 'bleeding out' automatons to kill them.
Blood on shoes/clothes etc is not changed currently due to it using the blend system which is more difficult to fix. however the whitescaled sprites are in the files incase someone wishes to work on it.
Will require Testmerging to just make sure everything is working correctly even after my own thorough tests.
Code Credits to @realforest2001 as the code was more infuriating to deal with than expected.
Why It's Good For The Game
Automatons bleed correctly now.
Blood now uses species blood rather than it being red by default.
Changelog
🆑
fix: Fixed blood not using the right colors.
image: Changed all wounds and blood to whitescale.
/:cl:
Pre-Merge Checklist