Add some audiovisual feedback for combat#5347
Open
CheffieGithub wants to merge 4 commits intoMonkestation:mainfrom
Open
Add some audiovisual feedback for combat#5347CheffieGithub wants to merge 4 commits intoMonkestation:mainfrom
CheffieGithub wants to merge 4 commits intoMonkestation:mainfrom
Conversation
|
I'd recommend making sure the sounds aren't too grating / noticeable for your playerbase as during any larger fights it overwhelms most other sounds. On top of that, due to the way integ works (it's not that hard to rapidly punch through the thresholds), they ended up playing frequently, too, thus creating a bit of a cacophany. I eventually went with different ones in this PR: Azure-Peak/Azure-Peak#5640 |
Collaborator
Author
|
Thanks for the heads up |
This was referenced Feb 23, 2026
Closed
|
the armor breaking popup seems to come up multiple times for some reason? like i'll be bashing a goblin's skull in, and his leather helmet breaks- then it breaks again, and again, then he dies from a crit, but i can only imagine it would continue breaking if i kept hitting it. |
This was referenced Feb 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Idea and partial port from azure Azure-Peak/Azure-Peak#4814.
Adds public balloon alerts to your armour breaking and at damage thresholds.
Add a private balloon alert to missing your selected damage zone.
The sounds may be too much like Free says below, feedback about them would be appreciated.
Why It's Good For The Game
Smashing a guy in the chest for minutes without feedback of what's happening isn't good
Changelog
🆑
add: Added public balloon alert feedback to armour breaking and at certain damage thresholds. (FreeStylaLT)
add: Added balloon alerts to missing swings on your targeted zone.
/:cl:
Pre-Merge Checklist