Updates toilets and adds a "used" variant#5386
Open
TerraGS wants to merge 2 commits intoMonkestation:mainfrom
Open
Updates toilets and adds a "used" variant#5386TerraGS wants to merge 2 commits intoMonkestation:mainfrom
TerraGS wants to merge 2 commits intoMonkestation:mainfrom
Conversation
github-actions
bot
added
Feature
|
The shittening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Changes toilets to use a storage component. Adds a subtype that will spawn containing 0-5 items. A small chance of finding coins in them, but most of the time what you'd expect. Reagent containers can interact with toilets.
Also fixed an issue with some reagent container icons not properly updating when emptying their contents.
Why It's Good For The Game
Toilets functionally are little more than set dressing currently, so this aims to give them more purpose and adding more of a lived-in feeling to maps. Toilets were also a mess of depreciated and unused code carried over from ss13 which this updates, removes or comments out.
Changelog
🆑
add: Adds pre-loaded toilets
fix: reagent container underlays properly update when emptied
map: replaces many toilets with the new subtype
code: Toilets now use a storage component. Removed cistern code.
/:cl:
Pre-Merge Checklist