Lighting updates / ports [MDB ignore]#5390
Draft
CheffieGithub wants to merge 4 commits intoMonkestation:mainfrom
Draft
Lighting updates / ports [MDB ignore]#5390CheffieGithub wants to merge 4 commits intoMonkestation:mainfrom
CheffieGithub wants to merge 4 commits intoMonkestation:mainfrom
Conversation
…g changes outer range. Port more optim (cache)
github-actions
bot
added
Code Maintenance
CheffieGithub
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Default area type is now one without dynamic lighting applied this to centcom and testing maps, this saves time mostly on roguetest due to the amount of these areas.
Fixes centcom dynamic lighting by adding it to our turf lists when its loaded.
Port multiple cleanup/optimsations of lighting
tgstation/tgstation#58991
tgstation/tgstation#59002
tgstation/tgstation#67678
tgstation/tgstation#69838
Removes custom falloff (Nothing uses it)
Removes outer_range (A very small amount of things use it for little gain)
This speeds up lighting init by:
~10 seconds on roguetest (~70%!)
~20 seconds on vanderlin (~50%!)
And will reduce maptick caused by having hundreds of thousands of movable light objects
todo
Why It's Good For The Game
Changelog
🆑
refactor: Big lighting refactor, somethings may be too dim or too bright, report issues.
/:cl:
Pre-Merge Checklist