Skip to content

Commit

Permalink
fix: button "Add Chart to Dashboard" visible before saving (frappe#23256
Browse files Browse the repository at this point in the history
)

* fix: dashboard chart - add chart to dashboard btn fix

* style: format

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
  • Loading branch information
Gubbu77 and ankush authored Nov 22, 2023
1 parent e2a7e54 commit a5b102d
Showing 1 changed file with 14 additions and 12 deletions.
26 changes: 14 additions & 12 deletions frappe/desk/doctype/dashboard_chart/dashboard_chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,21 @@ frappe.ui.form.on("Dashboard Chart", {
frm.disable_form();
}

frm.add_custom_button("Add Chart to Dashboard", () => {
const dialog = frappe.dashboard_utils.get_add_to_dashboard_dialog(
frm.doc.name,
"Dashboard Chart",
"frappe.desk.doctype.dashboard_chart.dashboard_chart.add_chart_to_dashboard"
);
if (!frm.is_new()) {
frm.add_custom_button("Add Chart to Dashboard", () => {
const dialog = frappe.dashboard_utils.get_add_to_dashboard_dialog(
frm.doc.name,
"Dashboard Chart",
"frappe.desk.doctype.dashboard_chart.dashboard_chart.add_chart_to_dashboard"
);

if (!frm.doc.chart_name) {
frappe.msgprint(__("Please create chart first"));
} else {
dialog.show();
}
});
if (!frm.doc.chart_name) {
frappe.msgprint(__("Please create chart first"));
} else {
dialog.show();
}
});
}

frm.set_df_property("filters_section", "hidden", 1);
frm.set_df_property("dynamic_filters_section", "hidden", 1);
Expand Down

0 comments on commit a5b102d

Please sign in to comment.