-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 add image update #424
base: v2
Are you sure you want to change the base?
V2 add image update #424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to put the HttpClient as a scoped service. Just create an instance and dispose it with the using expression.
using var httpClient = new HttpClient();
And use FirstOrDefault instead of Any + FindIndex. This reduces the db calls. If the item is missing the return value would be null |
The FindIndex and Any are called on a local list instead of the db |
So it would not really make a difference |
Another thing is that all server using the image need to have their variables updated too as they would stop working if the image varaibles get updated |
Oh, i didnt thought about that, i will do that later/tomorrow |
Oki. Thx for the help with moonlight. Take your time ^^ |
The Update Feature is doing: