Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.20.2 #215

Merged
merged 6 commits into from
Dec 28, 2023
Merged

Update to 1.20.2 #215

merged 6 commits into from
Dec 28, 2023

Conversation

MerchantPug
Copy link
Contributor

@MerchantPug MerchantPug commented Nov 5, 2023

  • Added QuiltMC maven to the repositories block in build.gradle, this was required for their build of GSON, which Origins now uses.
  • Added Modrinth maven to the repositories block in build.gradle, now required for Additional Entity Attributes.
  • Fixed foodEffectImmunity ModifyVariable inside SuspiciousStewItemMixin, there was an internal change to suspicious stew. Hopefully you don't mind my use of noneMatch, I found streams to be the most efficient here.
    The list was immutable, which is why I went the rebuild route.

I have not messed with the versioning of the mod, you'll have to increment that yourself. :3

@electricsteve
Copy link

The build error seems to be a problem with pehkui

@MerchantPug
Copy link
Contributor Author

The build error seems to be a problem with pehkui

I don't think that there should be a build error, I think that it was just that specific build fucking up. I didn't change anything in the build.gradle between the two commits.

@electricsteve
Copy link

hmmmm, ok maybe @MoriyaShiine needs to rerun it or just accept pr, my friends want the mod in their 1.20.2 server, but i did look at the file and it indeed did not exist

@JizzyJack
Copy link

hmmmm, ok maybe @MoriyaShiine needs to rerun it or just accept pr, my friends want the mod in their 1.20.2 server, but i did look at the file and it indeed did not exist

i have the same problem

@MerchantPug
Copy link
Contributor Author

MerchantPug commented Dec 23, 2023

Confirmed working with Origins 1.12.0 without any changes.

@MerchantPug
Copy link
Contributor Author

MerchantPug commented Dec 23, 2023

Updated dependencies on the dev side, and slightly bumped FMJ. Didn't bump FMJ all the way to allow it to work without latest loader, and slightly older origins versions.

@JizzyJack
Copy link

JizzyJack commented Dec 24, 2023

Confirmed working with Origins 1.12.0 without any changes. i just tried it, it isnt working the latest version is 1.20.1
Uploading origins pic.png…

@electricsteve
Copy link

Confirmed working with origins 1.12.0 without any changes. I just tried it, it isnt working the latest version is 1.20.1

  1. you didn't quote correctly
  2. if you are using the version that is on modrinth/curseforge, indeed, the code in the pr is not on modrinth/cf yet.

@MoriyaShiine MoriyaShiine merged commit 642ed0c into MoriyaShiine:main Dec 28, 2023
2 checks passed
@JizzyJack
Copy link

Confirmed working with origins 1.12.0 without any changes. I just tried it, it isnt working the latest version is 1.20.1

  1. you didn't quote correctly
  2. if you are using the version that is on modrinth/curseforge, indeed, the code in the pr is not on modrinth/cf yet.

Is there anyway to show me how to download it with curseforge please, I don’t know how to do it or what your saying

@electricsteve
Copy link

Confirmed working with origins 1.12.0 without any changes. I just tried it, it isnt working the latest version is 1.20.1

  1. you didn't quote correctly
  2. if you are using the version that is on modrinth/curseforge, indeed, the code in the pr is not on modrinth/cf yet.

Is there anyway to show me how to download it with curseforge please, I don’t know how to do it or what your saying

@MoriyaShiine needs to upload it to curseforge first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants