Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix repeat RSS issue #145

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix repeat RSS issue #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 81 additions & 51 deletions submodules/moragents_dockers/agents/src/agents/news_agent/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import logging
import re
import pyshorteners
from typing import List, Dict

from src.agents.news_agent.config import Config
from src.agents.news_agent.tools import clean_html, fetch_rss_feed, is_within_time_window
Expand All @@ -10,7 +11,6 @@

logger = logging.getLogger(__name__)


class NewsAgent(AgentCore):
"""Agent for fetching and analyzing cryptocurrency news."""

Expand All @@ -19,6 +19,7 @@ def __init__(self, config, llm, embeddings):
self.tools_provided = self.get_tools()
self.tool_bound_llm = self.llm.bind_tools(self.tools_provided)
self.url_shortener = pyshorteners.Shortener()
self.max_news_items = 2 # Hard limit of 2 news items total

def get_tools(self):
return [
Expand Down Expand Up @@ -64,8 +65,81 @@ async def _process_request(self, request: ChatRequest) -> AgentResponse:
content="I ran into an issue processing your request. Could you try rephrasing it?"
)

def _check_relevance_and_summarize(self, title: str, content: str, coin: str) -> str:
"""Check if news is relevant and generate summary."""
prompt = Config.RELEVANCE_PROMPT.format(coin=coin, title=title, content=content)
result = self.llm.invoke(
input=[{"role": "user", "content": prompt}],
max_tokens=Config.LLM_MAX_TOKENS,
temperature=Config.LLM_TEMPERATURE,
)
return result.content.strip()

def _process_rss_feed(self, feed_url: str, coin: str, remaining_slots: int) -> List[Dict]:
"""Process RSS feed and filter relevant articles with strict limits."""
if remaining_slots <= 0:
return []

logger.info(f"Processing RSS feed for {coin}: {feed_url}")
feed = fetch_rss_feed(feed_url)
results = []

# Only process up to 3 entries to avoid excessive API calls
for entry in (feed.entries or [])[:3]:
if len(results) >= remaining_slots:
break

published_time = entry.get("published") or entry.get("updated")
if not is_within_time_window(published_time):
continue

title = clean_html(entry.title)
content = clean_html(entry.summary)
result = self._check_relevance_and_summarize(title, content, coin)

if not result.upper().startswith("NOT RELEVANT"):
results.append({
"Title": title,
"Summary": result,
"Link": entry.link
})

logger.info(f"Found {len(results)} relevant articles for {coin}")
return results

def _fetch_crypto_news(self, coins: List[str]) -> List[Dict]:
"""Fetch and process news for specified coins with strict limits."""
logger.info(f"Fetching news for coins: {coins}")
all_news = []
remaining_slots = self.max_news_items

for coin in coins:
if remaining_slots <= 0:
break

logger.info(f"Processing news for {coin}")
coin_name = Config.CRYPTO_DICT.get(coin.upper(), coin)
google_news_url = Config.GOOGLE_NEWS_BASE_URL.format(coin_name)

results = self._process_rss_feed(
google_news_url,
coin_name,
remaining_slots
)

# Add results while respecting the total limit
for result in results[:remaining_slots]:
all_news.append({"Coin": coin, **result})
remaining_slots -= 1

if remaining_slots <= 0:
break

logger.info(f"Total news items fetched: {len(all_news)}")
return all_news

async def _execute_tool(self, func_name: str, args: dict) -> AgentResponse:
"""Execute the appropriate news tool based on function name."""
"""Execute the appropriate news tool based on function name with enforced limits."""
try:
if func_name == "fetch_crypto_news":
coins = args.get("coins", [])
Expand All @@ -80,7 +154,7 @@ async def _execute_tool(self, func_name: str, args: dict) -> AgentResponse:
content="No relevant news found for the specified cryptocurrencies in the last 24 hours."
)

response = "Here are the latest news items relevant to changes in price movement of the mentioned tokens in the last 24 hours:\n\n"
response = "Here are the latest news items that could impact token prices:\n\n"
for index, item in enumerate(news, start=1):
coin_name = Config.CRYPTO_DICT.get(item["Coin"], item["Coin"])
short_url = self.url_shortener.tinyurl.short(item["Link"])
Expand All @@ -92,55 +166,11 @@ async def _execute_tool(self, func_name: str, args: dict) -> AgentResponse:
return AgentResponse.success(content=response)
else:
return AgentResponse.needs_info(
content=f"I don't know how to handle that type of request. Could you try asking about cryptocurrency news instead?"
content="I don't know how to handle that type of request. Could you try asking about cryptocurrency news instead?"
)

except Exception as e:
logger.error(f"Error executing tool {func_name}: {str(e)}", exc_info=True)
return AgentResponse.needs_info(content="I encountered an issue fetching the news. Could you try again?")

def _check_relevance_and_summarize(self, title, content, coin):
"""Check if news is relevant and generate summary."""
logger.info(f"Checking relevance for {coin}: {title}")
prompt = Config.RELEVANCE_PROMPT.format(coin=coin, title=title, content=content)
result = self.llm.invoke(
input=[{"role": "user", "content": prompt}],
max_tokens=Config.LLM_MAX_TOKENS,
temperature=Config.LLM_TEMPERATURE,
)
return result.content.strip()

def _process_rss_feed(self, feed_url, coin):
"""Process RSS feed and filter relevant articles."""
logger.info(f"Processing RSS feed for {coin}: {feed_url}")
feed = fetch_rss_feed(feed_url)
results = []
for entry in (feed.entries or [])[:5]: # Process max 5 entries
published_time = entry.get("published") or entry.get("updated")
if is_within_time_window(published_time):
title = clean_html(entry.title)
content = clean_html(entry.summary)
logger.info(f"Checking relevance for article: {title}")
result = self._check_relevance_and_summarize(title, content, coin)
if not result.upper().startswith("NOT RELEVANT"):
results.append({"Title": title, "Summary": result, "Link": entry.link})
if len(results) >= Config.ARTICLES_PER_TOKEN:
break
else:
logger.info(f"Skipping article: {entry.title} (published: {published_time})")
logger.info(f"Found {len(results)} relevant articles for {coin}")
return results

def _fetch_crypto_news(self, coins):
"""Fetch and process news for specified coins."""
logger.info(f"Fetching news for coins: {coins}")
all_news = []
for coin in coins:
logger.info(f"Processing news for {coin}")
coin_name = Config.CRYPTO_DICT.get(coin.upper(), coin)
google_news_url = Config.GOOGLE_NEWS_BASE_URL.format(coin_name)
results = self._process_rss_feed(google_news_url, coin_name)
all_news.extend([{"Coin": coin, **result} for result in results[: Config.ARTICLES_PER_TOKEN]])

logger.info(f"Total news items fetched: {len(all_news)}")
return all_news
return AgentResponse.needs_info(
content="I encountered an issue fetching the news. Could you try again?"
)