Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes #287

Merged
merged 28 commits into from
Jan 8, 2025
Merged

Bugfixes #287

merged 28 commits into from
Jan 8, 2025

Conversation

softmattertheory
Copy link
Contributor

@softmattertheory softmattertheory commented Jan 8, 2025 •
edited
Loading

This PR includes many minor fixes and improvements, including:—

  1. Morpho run with valgrind now passes for the entire test suite, fixing a number of (minor) memory leaks.
  2. Improvements to Range class.
  3. Fix metafunction edge cases that vary by number of arguments.

The PR fixes the following outstanding issues:—

  1. [Bug] Overflow in mesh constructor #38 Overflow in Mesh constructor.
  2. [Bug] Exclusive ranges might skip last element #114 Range issues.
  3. Non indexable objects #217 Incorrect parameters to index()
  4. meanCurvatureSq Functional Documentation #239 Documentation for functionals improved.
  5. [Bug] MeshSlicer module not working with DelaunayMesh #283 MeshSlicer issue.

softmattertheory and others added 28 commits January 4, 2025 08:16
@softmattertheory
Improve help in functionals
f5f2187
@softmattertheory
Parser now distinguishes inclusive and exclusive ranges
1911ebd
@softmattertheory
Distinguish inclusive and exclusive ranges
48a9d05
@softmattertheory
Construct inclusive ranges explicitly
b262737
@softmattertheory
Fix metafunction compiler with vargs and multiple resolutions
ab8010f
@softmattertheory
Fix exclusive ranges
e079df4
@softmattertheory
Fix edge cases in Range
0facaf5
@softmattertheory
Classes are now bound to the program
9028ce1
@softmattertheory
Add valgrind test script
2813151
@softmattertheory
Bind try dictionary to the program
ba71faf
@softmattertheory
Merge branch 'fixes' of https://github.com/Morpho-lang/morpho into fixes
08e07f6
@softmattertheory
Free Sparse object after raising an error
83951c4
@softmattertheory
Generate error when a non-string parameter is passed to index
0835c6d
@softmattertheory
Global names are now bound to the program
9621e31
@softmattertheory
Bind metafunctions to program
453f938
@softmattertheory
Remove unused variables etc.
c196ecc
@softmattertheory
Fix memory leak if there's an error in slicing
086a3be
@softmattertheory
Fix deallocation of subkernels
38eee96
@softmattertheory
Close file if an error occurs in mesh loading
6418551
@softmattertheory
Fix potential memory leak in metafunction compilation
facc594
@softmattertheory
Missing bind in metafunction constructor
e3b09ef
@softmattertheory
Use pthread_join to ensure threads terminate on clear
7ccfbd9
@softmattertheory
Fix ranges with too small a stepsize and meshes that are too large
a05eec9
@softmattertheory
Update version-0.6.2.md
21e21b0
@softmattertheory
Add required header
9358159
@softmattertheory
Accept Matrix arguments to setpt
7a3ac15
@softmattertheory
Redirect error output
611dde7
@softmattertheory
Try redirecting all output
56e011e
@emmanuellfc emmanuellfc merged commit feef3a8 into dev Jan 8, 2025
5 checks passed
@softmattertheory softmattertheory deleted the fixes branch January 8, 2025 15:51
This was referenced Jan 8, 2025
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshichaitanya3 joshichaitanya3 Awaiting requested review from joshichaitanya3

@emmanuellfc emmanuellfc Awaiting requested review from emmanuellfc

@ConduitDan ConduitDan Awaiting requested review from ConduitDan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@softmattertheory @emmanuellfc