Improve testing

[yasserahmed10]

This pull request introduces several new test cases and updates to improve test coverage and maintainability across the codebase. The changes include adding unit tests for subtask-related use cases, renaming a test class for consistency, and enhancing the MapperKtTest to cover additional scenarios.

New test cases for subtask-related use cases:

• Added CreateSubTaskUseCaseTest to verify the creation of subtasks, including success, failure, and validation of the passed SubTask object. (src/test/kotlin/domain/usecases/sub_task/CreateSubTaskUseCaseTest.kt)
• Added DeleteSubTaskUseCaseTest to test the deletion of subtasks, ensuring correct behavior when the repository succeeds or fails, and validating the passed subtask ID. (src/test/kotlin/domain/usecases/sub_task/DeleteSubTaskUseCaseTest.kt)
• Added GetSubTasksByTaskIdUseCaseTest to test fetching subtasks by task ID, covering scenarios where the repository returns data, no data, and validating the task ID passed to the repository. (src/test/kotlin/domain/usecases/sub_task/GetSubTasksByTaskIdUseCaseTest.kt)
• Added UpdateSubTaskUseCaseTest to validate the update functionality for subtasks, including success, failure, and ensuring the correct SubTask object is passed to the repository. (src/test/kotlin/domain/usecases/sub_task/UpdateSubTaskUseCaseTest.kt)

Enhancements to existing tests:

• Enhanced MapperKtTest by adding tests for converting a String to a SubTask and converting a TaskDto to a Task with subtasks, improving coverage for mapping logic. (src/test/kotlin/data/mappers/MapperKtTest.kt)

Test class renaming for consistency:

• Renamed TaskStateDataSourceImplTest to TaskStateRepositoryImplTest to align with the updated naming conventions of the repository layer. (src/test/kotlin/data/repositories/TaskStateRepositoryImplTest.kt)

[github-actions]

Test Results

355 tests  +14   318 ✅ +14   10s ⏱️ ±0s
 66 suites + 4     0 💤 ± 0 
 66 files   + 4    37 ❌ ± 0 

For more details on these failures, see this check.

Results for commit 521bc3f. ± Comparison against base commit 6ee1efc.

This pull request removes 19 and adds 32 tests. Note that renamed tests count towards both.

data.repositories.TaskStateDataSourceImplTest ‑ addTask should store task in repository()
data.repositories.TaskStateDataSourceImplTest ‑ addTask should throw TaskIsExist when task with same ID already exists()
data.repositories.TaskStateDataSourceImplTest ‑ deleteTask should remove task from repository()
data.repositories.TaskStateDataSourceImplTest ‑ deleteTask should throw TaskIsNotFoundException when task does not exist()
data.repositories.TaskStateDataSourceImplTest ‑ editTask should modify existing task()
data.repositories.TaskStateDataSourceImplTest ‑ editTask should throw TaskIsNotFoundException when task does not exist()
data.repositories.TaskStateDataSourceImplTest ‑ editing task should not affect other tasks()
data.repositories.TaskStateDataSourceImplTest ‑ getAllTasks should return all tasks()
data.repositories.TaskStateDataSourceImplTest ‑ getTaskById should find correct task when multiple tasks have same project ID()
…

data.mappers.MapperKtTest ‑ test String to SubTask conversion()
data.mappers.MapperKtTest ‑ test TaskDto to Task conversion with subTasks()
data.repositories.TaskStateRepositoryImplTest ‑ addTask should store task in repository()
data.repositories.TaskStateRepositoryImplTest ‑ addTask should throw TaskIsExist when task with same ID already exists()
data.repositories.TaskStateRepositoryImplTest ‑ deleteTask should remove task from repository()
data.repositories.TaskStateRepositoryImplTest ‑ deleteTask should throw TaskIsNotFoundException when task does not exist()
data.repositories.TaskStateRepositoryImplTest ‑ editTask should modify existing task()
data.repositories.TaskStateRepositoryImplTest ‑ editTask should throw TaskIsNotFoundException when task does not exist()
data.repositories.TaskStateRepositoryImplTest ‑ editing task should not affect other tasks()
data.repositories.TaskStateRepositoryImplTest ‑ getAllTasks should return all tasks()
…

[github-actions]

❌ Test or Coverage checks failed! Please check the workflow run for details.

[github-actions]

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

• Register at Qodana Cloud and configure the action
• Use GitHub Code Scanning with Qodana
• Host Qodana report at GitHub Pages
• Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.3.4
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[Ahmedsayed0895]

Good job