Backdrop and Skybands Nodes for DAG #2362
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| /* | ||
| * Copyright 2016 MovingBlocks | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.terasology.rendering.dag; | ||
|
|
||
| import org.terasology.config.Config; | ||
| import org.terasology.config.RenderingDebugConfig; | ||
| import org.terasology.monitoring.PerformanceMonitor; | ||
| import org.terasology.registry.In; | ||
| import org.terasology.rendering.backdrop.BackdropRenderer; | ||
| import org.terasology.rendering.cameras.Camera; | ||
| import org.terasology.rendering.opengl.FBO; | ||
| import org.terasology.rendering.opengl.FrameBuffersManager; | ||
| import org.terasology.rendering.world.WorldRenderer; | ||
| import static org.terasology.rendering.opengl.OpenGLUtils.bindDisplay; | ||
| import static org.terasology.rendering.opengl.OpenGLUtils.disableWireframeIf; | ||
| import static org.terasology.rendering.opengl.OpenGLUtils.enableWireframeIf; | ||
| import static org.terasology.rendering.opengl.OpenGLUtils.setRenderBufferMask; | ||
| import static org.lwjgl.opengl.GL11.GL_COLOR_BUFFER_BIT; | ||
| import static org.lwjgl.opengl.GL11.GL_DEPTH_BUFFER_BIT; | ||
| import static org.lwjgl.opengl.GL11.GL_STENCIL_BUFFER_BIT; | ||
| import static org.lwjgl.opengl.GL11.glClear; | ||
|
|
||
|
|
||
| /** | ||
| * TODO: Diagram of this node | ||
| */ | ||
| public class BackdropNode implements Node { | ||
|
|
||
| @In | ||
| private Config config; | ||
|
|
||
| @In | ||
| private BackdropRenderer backdropRenderer; | ||
|
|
||
| @In | ||
| private WorldRenderer worldRenderer; | ||
|
|
||
| @In | ||
| private FrameBuffersManager frameBuffersManager; | ||
|
|
||
| private RenderingDebugConfig renderingDebugConfig; | ||
| private Camera playerCamera; | ||
| private FBO sceneOpaque; | ||
|
|
||
| @Override | ||
| public void initialise() { | ||
| renderingDebugConfig = config.getRendering().getDebug(); | ||
| playerCamera = worldRenderer.getActiveCamera(); | ||
| } | ||
|
|
||
| @Override | ||
| public void process() { | ||
| PerformanceMonitor.startActivity("rendering/backdrop"); | ||
| enableWireframeIf(renderingDebugConfig.isWireframe()); | ||
|
|
||
| sceneOpaque = frameBuffersManager.getFBO("sceneOpaque"); | ||
|
|
||
| initialClearing(); | ||
|
|
||
| sceneOpaque.bind(); | ||
| setRenderBufferMask(sceneOpaque, true, true, true); | ||
|
|
||
| playerCamera.lookThroughNormalized(); | ||
| /** | ||
| * Sets the state to render the Backdrop. At this stage the backdrop is the SkySphere | ||
| * plus the SkyBands passes. | ||
| * | ||
| * The backdrop is the only rendering that has three state-changing methods. | ||
| * This is due to the SkySphere requiring a state and the SkyBands requiring a slightly | ||
| * different one. | ||
| */ | ||
| setRenderBufferMask(sceneOpaque, true, false, false); | ||
| backdropRenderer.render(playerCamera); | ||
|
|
||
| disableWireframeIf(renderingDebugConfig.isWireframe()); | ||
| PerformanceMonitor.endActivity(); | ||
| } | ||
|
|
||
| /** | ||
| * Initial clearing of a couple of important Frame Buffers. Then binds back the Display. | ||
| */ | ||
| // It's unclear why these buffers need to be cleared while all the others don't... | ||
| private void initialClearing() { | ||
| FBO sceneReflectiveRefractive = frameBuffersManager.getFBO("sceneReflectiveRefractive"); | ||
| sceneOpaque.bind(); | ||
| glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT); | ||
| sceneReflectiveRefractive.bind(); | ||
| glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT); | ||
| bindDisplay(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| /* | ||
| * Copyright 2016 MovingBlocks | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.terasology.rendering.dag; | ||
|
|
||
| import org.terasology.config.Config; | ||
| import org.terasology.config.RenderingConfig; | ||
| import org.terasology.config.RenderingDebugConfig; | ||
| import org.terasology.monitoring.PerformanceMonitor; | ||
| import org.terasology.registry.In; | ||
| import org.terasology.rendering.assets.material.Material; | ||
| import org.terasology.rendering.cameras.Camera; | ||
| import org.terasology.rendering.opengl.FBO; | ||
| import org.terasology.rendering.opengl.FrameBuffersManager; | ||
| import org.terasology.rendering.world.WorldRenderer; | ||
| import static org.terasology.rendering.opengl.OpenGLUtils.bindDisplay; | ||
| import static org.terasology.rendering.opengl.OpenGLUtils.setViewportToSizeOf; | ||
| import static org.terasology.rendering.opengl.OpenGLUtils.disableWireframeIf; | ||
| import static org.terasology.rendering.opengl.OpenGLUtils.enableWireframeIf; | ||
| import static org.terasology.rendering.opengl.OpenGLUtils.renderFullscreenQuad; | ||
| import static org.terasology.rendering.opengl.OpenGLUtils.setRenderBufferMask; | ||
| import static org.lwjgl.opengl.GL11.GL_COLOR_BUFFER_BIT; | ||
| import static org.lwjgl.opengl.GL11.GL_DEPTH_BUFFER_BIT; | ||
| import static org.lwjgl.opengl.GL11.glClear; | ||
|
|
||
|
|
||
| /** | ||
| * TODO: Diagram of this node | ||
| * TODO: Separate this node into multiple SkyBandNode's | ||
| */ | ||
| public class SkyBandsNode implements Node { | ||
|
|
||
| @In | ||
| private Config config; | ||
|
|
||
| @In | ||
| private WorldRenderer worldRenderer; | ||
|
|
||
| @In | ||
| private FrameBuffersManager frameBuffersManager; | ||
|
|
||
| private RenderingConfig renderingConfig; | ||
| private Material blurShader; | ||
| private FBO sceneOpaque; | ||
| private FBO sceneSkyBand0; | ||
| private RenderingDebugConfig renderingDebugConfig; | ||
| private Camera playerCamera; | ||
|
|
||
| @Override | ||
| public void initialise() { | ||
| renderingConfig = config.getRendering(); | ||
| renderingDebugConfig = renderingConfig.getDebug(); | ||
| blurShader = worldRenderer.getMaterial("engine:prog.blur"); | ||
| playerCamera = worldRenderer.getActiveCamera(); | ||
| } | ||
|
|
||
| @Override | ||
| public void process() { | ||
| PerformanceMonitor.startActivity("rendering/skybands"); | ||
| enableWireframeIf(renderingDebugConfig.isWireframe()); | ||
|
|
||
| sceneOpaque = frameBuffersManager.getFBO("sceneOpaque"); | ||
|
|
||
| setRenderBufferMask(sceneOpaque, true, true, true); | ||
| if (renderingConfig.isInscattering()) { | ||
| sceneSkyBand0 = frameBuffersManager.getFBO("sceneSkyBand0"); | ||
| FBO sceneSkyBand1 = frameBuffersManager.getFBO("sceneSkyBand1"); | ||
|
|
||
| generateSkyBand(sceneSkyBand0); | ||
| generateSkyBand(sceneSkyBand1); | ||
| } | ||
|
|
||
| sceneOpaque.bind(); | ||
|
|
||
| playerCamera.lookThrough(); | ||
| disableWireframeIf(renderingDebugConfig.isWireframe()); | ||
| PerformanceMonitor.endActivity(); | ||
|
There was a problem hiding this comment. Good coding choice to clarify what would otherwise be hard to understand. However I'd solve the problem by having Performance Monitor statements at the beginning and end of each node. This is a change from what we have now, grouping together a number of rendering steps within the same activity. My vision is to group together activities by using hierarchical activity names instead. I.e. you could name the activity in the BackdropNode "rendering/backdrop" and the other "rendering/backdrop/skybands". It will be up to DebugOverlay to group these together if the user wishes it. Let me know if this is clear enough. There was a problem hiding this comment. You mean like: PerformanceMonitor.startActivity("rendering/backdrop") // Executed inside Backdrop
...
PerformanceMonitor.startActivity("rendering/backdrop/skybands") // Executed inside SkyBand node
...
PerformanceMonitor.endActivity("rendering/backdrop/skybands") // Executed inside SkyBand
PerformanceMonitor.endActivity("rendering/backdrop") // Executed not inside SkyBand, but inside BackdropBut the activity backdrop ( There was a problem hiding this comment. Regarding the activity statements: correct. Just remember endActivity() takes no parameter. Which won't be a problem now that start/end are closer to each other. Regarding your question: ideally, but only in a DebugOverlay. And initially I don't mind if it isn't. If the DebugOverlay is ordered alphabetically for example, related nodes will be listed near each other anyway. There could be an argument for naming rendering/backdrop more specifically. Or perhaps naming rendering/backdrop/skybands to rendering/skybands instead. In fact, I would prefer it that way. I am not convinced that the skybands should be grouped with the backdrop. If I remember correctly the generate some distant haze that gets overimposed on the world rendering. So, they are atmospheric effects on the world, not on the sky. So, I'd suggest rendering/backdrop and rendering/skybands for the time being. |
||
| } | ||
|
|
||
| private void generateSkyBand(FBO skyBand) { | ||
| blurShader.enable(); | ||
| blurShader.setFloat("radius", 8.0f, true); | ||
| blurShader.setFloat2("texelSize", 1.0f / skyBand.width(), 1.0f / skyBand.height(), true); | ||
|
|
||
| if (skyBand == sceneSkyBand0) { | ||
| sceneOpaque.bindTexture(); | ||
| } else { | ||
| sceneSkyBand0.bindTexture(); | ||
| } | ||
|
|
||
| skyBand.bind(); | ||
| setRenderBufferMask(skyBand, true, false, false); | ||
|
|
||
| setViewportToSizeOf(skyBand); | ||
| glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT); // TODO: verify this is necessary | ||
|
|
||
| renderFullscreenQuad(); | ||
|
|
||
| bindDisplay(); // TODO: verify this is necessary | ||
| setViewportToSizeOf(sceneOpaque); // TODO: verify this is necessary | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please enable AND disable wireframe in all nodes that were originally between the enableWireframeIf/disableWireframeIf statements in the WorldRendererImpl.render method. So, each of those nodes will need its own enable/disable pair. This of course has a small performance hit but we'll eventually solve it with state management.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you mean these two nodes also need a
disableWireframeIfstatement at the end ofprocess()method? Should changed states for a certain node in OpenGL be reverted and left for our state management?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.