Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rendering): avoid glBindFramebufferEXT to fix MacOS crash #5260

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

skaldarnar
Copy link
Member

@skaldarnar skaldarnar commented Jul 14, 2024

  • replace GL_FRAMEBUFFER_EXTwith GL_FRAMEBUFFER
  • replace glBindFramebufferEXT with glBindFramebuffer

Resolves #5242
Resolves #5055

Co-authored-by: a-ivanov (@a-ivanov)

@jdrueckert
Copy link
Member

Read up a bit, seems like the EXT variants are for extension support for FBO which was necessary for OpenGL < 3.0
Since OpenGL 3.0 FBOs are supported as a core feature, so the "regular" calls can be used.
As per our download page we require OpenGL 3.3, so I believe we can safely merge this.

@jdrueckert jdrueckert added this to the 2023 Revive - Milestone 4 milestone Jul 14, 2024
@jdrueckert jdrueckert merged commit ae00db7 into develop Jul 14, 2024
14 checks passed
@jdrueckert jdrueckert deleted the fix/avoid-glBindFramebufferEXT branch July 14, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues reporting and PRs fixing problems
Projects
Status: No status
2 participants