Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: upgrade to Gestalt 8" #5270

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

jdrueckert
Copy link
Member

Reverts #5267

We currently do not have an explicit dependency of modules on specific engine versions.
Modules implicitly depend on the latest engine build.
With this PR already merged, it is not possible to build and release modules without the associated required gestalt 8 upgrade module changes.

Reverting this to first publish those pre-gestalt-8-upgrade module versions.
Afterwards we can merge the engine PR for the gestalt 8 upgrade again and then the associated module PRs for the gestalt 8 upgrade according to the module dependency chain (Inventory first, then Behaviors and Furnishings in arbitrary order)

@jdrueckert jdrueckert added the Type: Chore Request for or implementation of maintenance changes label Aug 3, 2024
@jdrueckert jdrueckert added this to the 2023 Revive - Milestone 4 milestone Aug 3, 2024
@jdrueckert jdrueckert self-assigned this Aug 3, 2024
@github-actions github-actions bot added the Type: Improvement Request for or addition/enhancement of a feature label Aug 3, 2024
@jdrueckert jdrueckert merged commit 1cabdb3 into develop Aug 3, 2024
18 of 19 checks passed
jdrueckert added a commit that referenced this pull request Aug 3, 2024
jdrueckert added a commit that referenced this pull request Aug 4, 2024
@jdrueckert jdrueckert deleted the revert-5267-feat/gestalt-8-upgrade branch August 4, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Chore Request for or implementation of maintenance changes Type: Improvement Request for or addition/enhancement of a feature
Projects
Status: No status
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant