New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa: address pmd findings #5274

Merged

soloturn merged 12 commits into develop from qa/pmd-warnings

Oct 4, 2024

Merged

qa: address pmd findings #5274

Merge branch 'develop' into qa/pmd-warnings

Terasology Jenkins.io / Open Tasks Scanner succeeded Oct 4, 2024 in 0s

4 new issues, 445 total

Total	New	Outstanding	Fixed	Trend
445	4	441	3	👎

Reference build: Terasology » engine » develop #85

Details

Severity distribution of new issues

Error	Warning High	Warning Normal	Warning Low
0	0	4	0

Annotations

Check warning on line 175 in engine/src/main/java/org/terasology/engine/rendering/assets/skeletalmesh/SkeletalMeshData.java

terasology-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
Better algorithm (take into account triangle size and angles

Check warning on line 363 in engine/src/main/java/org/terasology/engine/rendering/nui/layers/mainMenu/UniverseSetupScreen.java

terasology-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
this will likely fail at game creation time later-on due to lack of world generator - don't just ignore this

Check warning on line 72 in engine/src/main/java/org/terasology/engine/world/time/WorldTimeImpl.java

terasology-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
consider catching / logging this case (someplace better than here)

Check warning on line 77 in engine/src/main/java/org/terasology/engine/world/time/WorldTimeImpl.java

terasology-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
consider sending a DailyTick (independent from solar events such as midnight)

View more details on Terasology Jenkins.io