Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark flaky tests with flaky tag #5278

Merged
merged 1 commit into from
Sep 29, 2024
Merged

test: mark flaky tests with flaky tag #5278

merged 1 commit into from
Sep 29, 2024

Conversation

jdrueckert
Copy link
Member

Contains

Adding the flaky tag to the ExampleTest.testSendEvent and DelayManagerTest.delayedActionIsTriggeredTest tests.

@jdrueckert
test: mark flaky tests with flaky tag
826667b 
- testSendEvent
- delayedActionIsTriggeredTest
@jdrueckert jdrueckert added Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes labels Sep 29, 2024
@jdrueckert jdrueckert self-assigned this Sep 29, 2024
@jdrueckert jdrueckert added this to the 2023 Revive - Milestone 4 milestone Sep 29, 2024
@jdrueckert
Copy link
Member Author

@BenjaminAmos as discussed in today's reviver sync, I marked the sporadically failing tests flaky.
With this, they will be run in CI as part of the "flaky tests" stage instead of the "non-flaky tests" stage that they were part of so far.
This will hopefully improve the developer experience as less PRs are blocked by sporadic failures until we get to investigate these sporadics in depth.

@jdrueckert jdrueckert merged commit d2810e6 into develop Sep 29, 2024
31 of 32 checks passed
@jdrueckert jdrueckert deleted the test/mark-flaky-tests branch September 29, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminAmos BenjaminAmos BenjaminAmos approved these changes

Assignees

@jdrueckert jdrueckert

Labels
Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Chore Request for or implementation of maintenance changes
Projects
Terasology Inbox
Status: No status
Terasology Stabilization
Status: No status
Milestone
2023 Revive - Milestone 4
Development

Successfully merging this pull request may close these issues.
2 participants
@jdrueckert @BenjaminAmos