Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Nav] fix newsletter signup issues on mobile nav #12313

Merged
merged 3 commits into from
May 7, 2024

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented May 7, 2024

  • on mobile nav, you should be able to scroll down to the newsletter signup button even when there's an open accordion
  • on mobile nav, newsletter signup button should toggle on the signup form screen just like what we have currently on production

Related PRs/issues: #12309

┆Issue is synchronized with this Jira Story

@mmmavis mmmavis force-pushed the 12309-mobile-nav-newsletter-button branch 2 times, most recently from 2c541fb to 8cdb6ef Compare May 7, 2024 19:52
@mmmavis mmmavis force-pushed the 12309-mobile-nav-newsletter-button branch from 8cdb6ef to 19da506 Compare May 7, 2024 20:23
@mmmavis mmmavis temporarily deployed to foundation-s-12309-mobi-ggz2dh May 7, 2024 20:51 Inactive
@mmmavis mmmavis requested a review from danielfmiranda May 7, 2024 21:01
@mmmavis mmmavis marked this pull request as ready for review May 7, 2024 21:01
@mmmavis mmmavis changed the title [WIP] [New Nav] fix newsletter signup issues on mobile nav [New Nav] fix newsletter signup issues on mobile nav May 7, 2024
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved!

@mmmavis mmmavis merged commit 6c2a567 into main May 7, 2024
6 checks passed
@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

PR has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants