Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing password protected page #13156

Merged
merged 9 commits into from
Nov 26, 2024

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Nov 19, 2024

Description

This PR customizes the password page based on the provided Figma design. I followed Wagtail doc for the implementation.

Link to sample test page: https://foundation-s-13100-tp1--v4m50x.herokuapp.com/en/who-we-are/test-password-protected-page/ (Password: test)
Related PRs/issues: #13100

┆Issue is synchronized with this Jira Story

@mmmavis mmmavis temporarily deployed to foundation-s-13100-tp1--v4m50x November 19, 2024 20:49 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-13100-tp1--v4m50x November 19, 2024 22:19 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-13100-tp1--v4m50x November 19, 2024 23:03 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-13100-tp1--v4m50x November 20, 2024 23:29 Inactive
@mmmavis mmmavis requested review from ramram-mf and nancyt1 November 20, 2024 23:31
@mmmavis mmmavis marked this pull request as ready for review November 21, 2024 00:05
Copy link
Collaborator

@nancyt1 nancyt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love!!! Seeing it now, can I request we capitalize all the Ps -> "Password Protected Page"?

@mmmavis mmmavis temporarily deployed to foundation-s-13100-tp1--v4m50x November 21, 2024 22:49 Inactive
@mmmavis mmmavis requested a review from nancyt1 November 22, 2024 18:09
@mmmavis
Copy link
Collaborator Author

mmmavis commented Nov 22, 2024

PR updated! @nancyt1

Copy link
Collaborator

@nancyt1 nancyt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@mmmavis mmmavis temporarily deployed to foundation-s-13100-tp1--v4m50x November 23, 2024 03:08 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-13100-tp1--v4m50x November 26, 2024 18:11 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-13100-tp1--v4m50x November 26, 2024 18:13 Inactive
Copy link
Collaborator

@ramram-mf ramram-mf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Mavis, thanks!

@mmmavis mmmavis merged commit c3449f0 into main Nov 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants