Skip to content

fix the vibecoded ui#585

Open
M1noa wants to merge 6 commits intoMr-Homeless:mainfrom
M1noa:main
Open

fix the vibecoded ui#585
M1noa wants to merge 6 commits intoMr-Homeless:mainfrom
M1noa:main

Conversation

@M1noa
Copy link

@M1noa M1noa commented Oct 1, 2025

i redesigned it and made them call a central style.css file instead of using style tags in the files themselves

image

i also added auto downloading and verifying for the hugging face models in install.sh & wsl-setup.bat

@M1noa M1noa marked this pull request as ready for review October 1, 2025 16:46
M1noa added 2 commits October 1, 2025 12:03
and wsl-install.bat auto restarts if not interupted after 15s timer starts
@StroepWafel
Copy link

Danny you beat me to it, I was gonna do this lol, saw it in the video and went 'eww thats gross'

@cwdaniel
Copy link

cwdaniel commented Oct 2, 2025

This PR goes beyond its stated scope of “fixing the vibe-coded UI.” It also introduces:

  • Autodownload functionality in the install scripts.
  • Readme language updates.

These changes should ideally be separated into distinct PRs for clarity and reviewability.

Concerns and Recommendations

Model Download

  • The script auto-downloads a 1.9 GB model from Hugging Face without checksum or signature verification, and only checks file size.
  • This is brittle and unsafe from a supply-chain perspective.
  • Recommendation: At minimum, verify a SHA-256 hash, pin to a specific revision/commit, and handle failures cleanly.

Repository Hygiene

  • The script writes deepcheat/vit_g_ps14_ak_ft_ckpt_7_clean.pth locally, but .gitignore doesn’t exclude it.
    -.pyd appears duplicated as well.
  • Recommendation: Add ignores for deepcheat/**.pth (or the directory) to prevent accidental commits, and remove duplicate ignore patterns.

UI JavaScript Performance & Accessibility

- static/main.js attaches mousemove listeners to every .card, .panel, .interactive, and <tr>, updating CSS variables on each frame.

  • On pages with many rows/cards, this causes jank and degrades performance. It also harms keyboard-only users.
  • Recommendation:
    -- Throttle or wrap updates in requestAnimationFrame.
    -- Scope listeners to only the necessary interactive elements (avoid blanket <tr> bindings).
    -- Ensure keyboard/focus styles provide parity with hover effects.

@M1noa
Copy link
Author

M1noa commented Oct 2, 2025

i added the features after i made the pull request and accidentally pushed them i didn't even notice lol

ill implament fixes and remove the mouse stuff (i had it there as i was planning to add a glow effect around the mouse when hovering on cards but forgot about it after a bit)

Deleted static/main.js, modified install.sh and wsl-setup.bat to verify model file integrity via SHA-256 after download, updated .gitignore to exclude model files and temporary directories

fixed all things mentioned in Mr-Homeless#585 (comment)
@M1noa
Copy link
Author

M1noa commented Oct 2, 2025

fixed it all in the latest commit a6edcb548e5c6b437f60bf73d945df325648848c

@M1noa
Copy link
Author

M1noa commented Oct 2, 2025

you could also automate the shai-256 part via using the git lfs info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants