Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd optional arg to not render terminal window #7

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

BoogerMan2103
Copy link

Added new functionality: choice to draw a terminal window or not

In some cases it was needed to be rendered without terminal window, to show how something looks like on Linux but not MacOS

Tests:

task: [test] go test  -failfast -race -coverpkg=./... -covermode=atomic -coverprofile=coverage.txt ./... -run . -timeout=5m
?       github.com/mrmarble/termsvg/cmd/termsvg [no test files]
?       github.com/mrmarble/termsvg/cmd/termsvg/export  [no test files]
?       github.com/mrmarble/termsvg/cmd/termsvg/play    [no test files]
?       github.com/mrmarble/termsvg/cmd/termsvg/rec     [no test files]
?       github.com/mrmarble/termsvg/internal/testutils  [no test files]
?       github.com/mrmarble/termsvg/pkg/color   [no test files]
ok      github.com/mrmarble/termsvg/internal/svg        0.497s  coverage: 78.6% of statements in ./...
ok      github.com/mrmarble/termsvg/internal/uniqueid   0.529s  coverage: 100.0% of statements in ./...
ok      github.com/mrmarble/termsvg/pkg/asciicast       1.038s  coverage: 78.6% of statements in ./...
ok      github.com/mrmarble/termsvg/pkg/css     0.781s  coverage: 21.4% of statements in ./...

I am not a Go expert and of course all my changes may be rejected

@MrMarble
Copy link
Owner

Thank you for your contribution! I'm happy people use the tools I build for fun!

@MrMarble MrMarble merged commit 51921a6 into MrMarble:master Feb 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants