Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize code #49

Closed
wants to merge 2 commits into from
Closed

feat: optimize code #49

wants to merge 2 commits into from

Conversation

eramitgupta
Copy link

Changes Made:
Extract Variables: Extracted search, sortBy, direction, and published from the request to make the when conditions more readable.

Concise when Conditions: Used shorthand fn syntax for inline functions.

Simplified view Call: Used compact('posts') for a cleaner way to pass the variable to the view.

@MrPunyapal
Copy link
Owner

Can you run the composer test 🤔

@eramitgupta
Copy link
Author

Screenshot 2024-08-10 at 9 19 42 PM @MrPunyapal I don't understand what this is

ERROR Type coverage below expected: 99.8%. Minimum: 100.0%

Script pest --type-coverage --min=100 handling the test:type-coverage event returned with error code 1
Script @test:type-coverage was called via test

@MrPunyapal
Copy link
Owner

Parameter type is missing on line number 29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants