Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom port support #48

Merged
merged 6 commits into from
Mar 22, 2024
Merged

feat: Add custom port support #48

merged 6 commits into from
Mar 22, 2024

Conversation

kemchenj
Copy link
Contributor

@kemchenj kemchenj commented Feb 6, 2024

Pull Request

Related issue(s)

Description

Due to some security concerns, some server might have a custom port for ssh instead of the default 22 port. It would be nice to have custom port support in this action.

kemchenj and others added 6 commits February 6, 2024 18:17
Signed-off-by: Guillaume Bonnet <mrsquaare@mrsquaare.fr>
Signed-off-by: Guillaume Bonnet <mrsquaare@mrsquaare.fr>
Signed-off-by: Guillaume Bonnet <mrsquaare@mrsquaare.fr>
Signed-off-by: Guillaume Bonnet <mrsquaare@mrsquaare.fr>
@MrSquaare
Copy link
Owner

MrSquaare commented Mar 22, 2024

Hello! Sorry for the long delay and thanks for the contribution! I took the opportunity to migrate to pnpm and bump the dependencies.

Tests fail because secrets aren't shared with forks, so this is normal!
(After merge with workflow dispatch: https://github.com/MrSquaare/ssh-setup-action/actions/runs/8396465996)

@MrSquaare MrSquaare self-requested a review March 22, 2024 21:07
@MrSquaare MrSquaare merged commit 2d028b7 into MrSquaare:main Mar 22, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants