Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agnostic helix finder and correction of the charged pion lifetime #1210
Agnostic helix finder and correction of the charged pion lifetime #1210
Changes from 43 commits
340b866
23c68d3
4239a11
7c37ef7
e18faa2
787c321
5561b6b
0699253
db36f13
2c379aa
393ec80
945813e
69dfe24
ae54f21
0be99c5
235da9d
b953053
bdb7ecc
071f641
e2f976a
dc4a23a
d98351f
a673c96
5ee711e
0ebcd55
bec3987
39a7a61
13b447c
a57ad67
697c370
5d924f2
5afcf2a
365bbc8
02062be
7467f3f
d5015fa
b49e324
f9516b4
304fa7f
802b0c5
59277ed
c622f75
5e53cc0
612500e
1e5d479
b7a261b
52a86d7
bde3c55
c3cbf76
a92287f
c5f656a
86d06b7
ebc9f7a
08fc1ae
3a42755
673869c
40c45d5
26b1b2b
6cda914
b926632
143b331
4eb209a
3978b11
c4b32e9
4ccb9b7
6973850
53ca285
9fd3069
6c47133
d5c2154
94b1775
cc22fe1
492fca6
cf56377
8897edf
bf54ad6
7c6fc89
a6be539
d99670e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this structure? Its content is identical to StrawId, and all of the functionality ( station, plane, face, panel) is available through accessor functions in StrawId. Having multiple structures represent ingthe same data is confusing and exposes the code to errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an internal for the algorithm helper class which returns hit indices ordered in Z. This functionality is not provided by the StrawId class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what functionality is not provided by StrawId?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the time when the code has been developed, the StrawId interface was not providing an ordering of the faces in assending global Z. As you already mentioned, it might be a good idea to integrate this functionality into the StrawId class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will start an issue and assign it for resolution after this PR