Agnostic helix finder and correction of the charged pion lifetime #1210
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| #ifndef CalPatRec_AgnosticHelixFinder_types_hh | ||
| #define CalPatRec_AgnosticHelixFinder_types_hh | ||
|
|
||
| #include "fhiclcpp/types/Atom.h" | ||
|
|
||
| namespace mu2e { | ||
|
|
||
| namespace AgnosticHelixFinderTypes { | ||
|
|
||
| struct Config { | ||
| fhicl::Atom<std::string> tool_type{fhicl::Name("tool_type"), fhicl::Comment("tool type: AgnosticHelixFinderDiag")}; | ||
| }; | ||
|
|
||
| struct tcInfo { | ||
| int nHelices; | ||
| int nComboHits; | ||
| int nStrawHits; | ||
| float time; | ||
| }; | ||
|
|
||
| struct lineSegmentInfo { | ||
| float chi2dof; | ||
| float maxHitGap; | ||
| }; | ||
|
|
||
| struct diagInfo { | ||
| float moduleTime; | ||
| int nHelices; | ||
| int nTimeClusters; | ||
| std::vector<tcInfo> timeClusterData; | ||
| std::vector<lineSegmentInfo> lineSegmentData; | ||
| }; | ||
|
|
||
| } // namespace AgnosticHelixFinderTypes | ||
| } // namespace mu2e | ||
| #endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| #ifndef CalPatRec_inc__enums_hh | ||
| #define CalPatRec_inc__enums_hh | ||
|
|
||
| #include "Offline/DataProducts/inc/StrawId.hh" | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| #ifndef __CalPatRec_inc_ChannelID_hh__ | ||
| #define __CalPatRec_inc_ChannelID_hh__ | ||
|
|
||
| namespace CalPatRec { | ||
| struct ChannelID { | ||
| int Station; | ||
| int Plane; | ||
| int Face; | ||
| int Panel; | ||
|
|
||
| static void orderID (ChannelID* X, ChannelID* Ordered); | ||
| static void deOrderID(ChannelID* X, ChannelID* Ordered); | ||
|
|
||
| static void testOrderID (); | ||
| static void testdeOrderID(); | ||
| }; | ||
| } | ||
|
|
||
| #endif | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this structure? Its content is identical to StrawId, and all of the functionality ( station, plane, face, panel) is available through accessor functions in StrawId. Having multiple structures represent ingthe same data is confusing and exposes the code to errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an internal for the algorithm helper class which returns hit indices ordered in Z. This functionality is not provided by the StrawId class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what functionality is not provided by StrawId?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the time when the code has been developed, the StrawId interface was not providing an ordering of the faces in assending global Z. As you already mentioned, it might be a good idea to integrate this functionality into the StrawId class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will start an issue and assign it for resolution after this PR