Skip to content

Fix: Update column name from TIME to DATE #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omariqbalnaru wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Update column name from TIME to DATE #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/psx/web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

class DataReader:

headers = ['TIME', 'OPEN', 'HIGH', 'LOW', 'CLOSE', 'VOLUME']
headers = ['DATE', 'OPEN', 'HIGH', 'LOW', 'CLOSE', 'VOLUME']

def __init__(self):
self.__history = "https://dps.psx.com.pk/historical"
Expand Down Expand Up @@ -78,11 +78,11 @@ def toframe(self, data):
cols = [col.getText() for col in row.select("td")]

for key, value in zip(self.headers, cols):
if key == "TIME":
if key == "DATE":
value = datetime.strptime(value, "%b %d, %Y")
stocks[key].append(value)

return pd.DataFrame(stocks, columns=self.headers).set_index("TIME")
return pd.DataFrame(stocks, columns=self.headers).set_index("DATE")

def daterange(self, start: date, end: date) -> list:
period = end - start
Expand Down