Skip to content

fixed metaABaCo.fit() with VMM prior #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edircoli merged 2 commits into from
Aug 14, 2025
Merged

fixed metaABaCo.fit() with VMM prior #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd541e4
fixed metaABaCo.fit() with VMM prior
edircoli Aug 13, 2025
11261a6
Merge branch 'main' into ecoli-19-metaabacofit-with-vmm
edircoli Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/abaco/ABaCo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4418,11 +4418,22 @@ def fit(
adv_lr=1e-3,
):
# Define optimizer
if isinstance(self.vae.prior, MoCPPrior):
prior_params = self.vae.prior.parameters()

elif isinstance(self.vae.prior, VMMPrior):
prior_params = [self.vae.prior.u, self.vae.prior.var]

else:
raise NotImplementedError(
"metaABaCo prior distribution can only be 'MoG' or 'VMM'"
)

vae_optimizer_1 = torch.optim.Adam(
[
{"params": self.vae.encoder.parameters()},
{"params": self.vae.decoder.parameters()},
{"params": self.vae.prior.parameters()},
{"params": prior_params},
],
lr=phase_1_vae_lr,
)
Expand Down
Loading