Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add opt-out support for bevy_eventlistener #16

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

musjj
Copy link
Contributor

@musjj musjj commented Apr 17, 2024

This adds support for bevy_eventlistener, which allows users to attach callbacks to entities and have it react to events targeting that entity.

This doesn't affect users who don't use it and they will still be able to listen to the events normally using EventReader<SpanTweenerEnded>. So I made the feature opt-out, but I'm open to making it an opt-in too if there are good reasons to.

@Multirious
Copy link
Owner

I usually preferred 3rd party crate to be opt-in but eventlistener does goes really well with the design of this crate. Opt-out should be good.

src/span_tween.rs Show resolved Hide resolved
@Multirious Multirious merged commit 4351cc5 into Multirious:main Apr 17, 2024
3 checks passed
@Multirious
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants