Google cloud storage added in source #650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/new-source-google-cloud-storage
…o feature/new-source-google-cloud-storage
hassimnaseef
pushed a commit
that referenced
this pull request
Mar 20, 2025
Co-authored-by: codiumai-pr-agent-pro[bot] <151058649+codiumai-pr-agent-pro[bot]@users.noreply.github.com> Co-authored-by: sangkum <sangit.kumar@squared.ai>
… client implemented
…h the sources list - 400 error resolved
|
@developerJai could you please split the PR for Google Cloud Storage into separate ones for source and destination? |
afthabvp
reviewed
Mar 21, 2025
Comment on lines
86
to
94
| storage = Google::Cloud::Storage.new( | ||
| project_id: project_id, | ||
| credentials: { | ||
| type: "service_account", | ||
| project_id: project_id, | ||
| private_key: formatted_key, | ||
| client_email: client_email | ||
| } | ||
| ) |
There was a problem hiding this comment.
@developerJai please move this to a separate method and call it to avoid duplication.
afthabvp
reviewed
Mar 21, 2025
Comment on lines
15
to
27
| # Validate required parameters | ||
| missing_params = [] | ||
| missing_params << "project_id" if project_id.nil? || project_id.strip.empty? | ||
| missing_params << "client_email" if client_email.nil? || client_email.strip.empty? | ||
| missing_params << "private_key" if private_key.nil? || private_key.strip.empty? | ||
| missing_params << "bucket" if bucket.nil? || bucket.strip.empty? | ||
|
|
||
| if missing_params.any? | ||
| return ConnectionStatus.new( | ||
| status: ConnectionStatusType["failed"], | ||
| message: "Missing required parameters: #{missing_params.join(', ')}" | ||
| ).to_multiwoven_message | ||
| end |
There was a problem hiding this comment.
@developerJai the empty validation is not required, as the JSON schema already validates these fields.
afthabvp
reviewed
Mar 21, 2025
| end | ||
|
|
||
| begin | ||
| require 'google/cloud/storage' |
There was a problem hiding this comment.
@developerJai this import not required
afthabvp
reviewed
Mar 21, 2025
Comment on lines
97
to
112
| bucket_obj = storage.bucket(bucket) | ||
|
|
||
| # Prepare the path prefix | ||
| prefix = path.start_with?("/") ? path[1..-1] : path | ||
|
|
||
| # List files in the bucket with the given prefix | ||
| files = bucket_obj.files(prefix: prefix) | ||
|
|
||
| # Filter files by file type | ||
| files = files.select { |file| file.name.end_with?(".#{file_type}") } | ||
|
|
||
| if files.empty? | ||
| return Catalog.new( | ||
| streams: [] | ||
| ).to_multiwoven_message | ||
| end |
There was a problem hiding this comment.
@developerJai please move the file validation inside the check_connection method. The discover method should only handle returning the catalog.
…nd successfully created a model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Cloud Storage source integration implemented