Fix connectivity issues, switch from http-bind to websocket #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.5.0 to 4.5.2. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
anonymousdomain is required to login as guest. The serviceUrl has been changed to websocket which should be more efficient than http-bind
After changing to websocket instead of http-bind this rule is not required anymore since websockets are not effected by CORS. The extension is now only required for streaming from googlevideo
Switched to websocket from http-bind, see previous commits
…arn/frontend/vite-4.5.2 Bump vite from 4.5.0 to 4.5.2 in /frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the connectivity issues reported in #154. The
boshparameter has been changed toserviceUrlinlib-jitsi-meetwhich supports websockets instead ofhttp-bind. Websocket are apparently not subject to CORS so the http-bind related stuff has been removed from the browser extension. The extension is now solely required for streaming from google video, meaning that Jimmi could be used as a Chatbot without the plugin.Checklist
dev. Don't request tomainbranch!