New command stickernamestypes #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jcorporation
force-pushed
the
stickernames-types
branch
2 times, most recently
from
7b35285
to
6058cf8
Compare
src/command/StickerCommands.cxx
Outdated
| @@ -122,6 +122,25 @@ class DomainHandler { | |||
| return CommandResult::OK; | |||
| } | |||
|
|
|||
| virtual CommandResult NamesTypes(const char *type) { | |||
There was a problem hiding this comment.
Why is this method virtual?
There was a problem hiding this comment.
That was not a deliberate decision. All other functions in this class are also defined in this way. I have removed the virtual keyword.
Lists sticker names with their types and optionally filters by type
jcorporation
force-pushed
the
stickernames-types
branch
from
6058cf8
to
26c4211
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lists sticker names with their types and optionally filters by type